Add _total suffix to prometheus counters #2288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
counter_total_suffix
branch
2 times, most recently
from
bc16feb to
35d03b3
Compare
Codecov Report
@@ Coverage Diff @@
## main #2288 +/- ##
=======================================
Coverage 87.52% 87.52%
=======================================
Files 199 199
Lines 5981 5981
=======================================
Hits 5234 5234
Misses 747 747 |
dashpole
force-pushed
the
counter_total_suffix
branch
4 times, most recently
from
e25e527 to
a64dec8
Compare
dashpole
force-pushed
the
counter_total_suffix
branch
from
a64dec8 to
ed46cdd
Compare
|
Duplicate of #2213 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2287
Changes
Append _total suffix to Prometheus counters. This is done by: